Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20952#discussion_r180187517
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -125,6 +126,7 @@ private[history] class FsHistoryProvider(conf: 
SparkConf, clock: Clock)
       private val pendingReplayTasksCount = new 
java.util.concurrent.atomic.AtomicInteger(0)
    --- End diff --
    
    The class comment is no longer correct when it talks about finding new 
attempts based on modification time.  You should have a listing entry for every 
file in the dir


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to