Github user Ngone51 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20996#discussion_r180347526
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
    @@ -370,12 +370,10 @@ private[spark] class TaskSchedulerImpl(
           }
           if (!launchedAnyTask) {
             taskSet.abortIfCompletelyBlacklisted(hostToExecutors)
    +      } else {
    +        hasLaunchedTask = true
    --- End diff --
    
    Hi, @jiangxb1987 Thanks for your comment.
    From the usage of `hasLaunchedTask `  seems it is related to resources 
offer. But for the name itself, it is not correct. uh, maybe, trivial.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to