Github user jose-torres commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21029#discussion_r180489842
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala 
---
    @@ -143,7 +144,7 @@ case class MemoryStream[A : Encoder](id: Int, 
sqlContext: SQLContext)
           logDebug(generateDebugString(newBlocks.flatten, startOrdinal, 
endOrdinal))
     
           newBlocks.map { block =>
    -        new 
MemoryStreamDataReaderFactory(block).asInstanceOf[DataReaderFactory[UnsafeRow]]
    +        new 
MemoryStreamDataReaderFactory(block).asInstanceOf[DataReaderFactory]
    --- End diff --
    
    I'd like that, but I don't know if that would make things harder for data 
source implementers working in Java.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to