Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19627#discussion_r180876558
  
    --- Diff: python/pyspark/ml/tests.py ---
    @@ -1018,6 +1018,48 @@ def test_parallel_evaluation(self):
             cvParallelModel = cv.fit(dataset)
             self.assertEqual(cvSerialModel.avgMetrics, 
cvParallelModel.avgMetrics)
     
    +    def test_expose_sub_models(self):
    --- End diff --
    
    Nice tests.  Can you make one addition: Test the copy() method to make sure 
it copies the submodels.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to