Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19627#discussion_r180874011
  
    --- Diff: python/pyspark/ml/tuning.py ---
    @@ -194,7 +195,8 @@ def _to_java_impl(self):
             return java_estimator, java_epms, java_evaluator
     
     
    -class CrossValidator(Estimator, ValidatorParams, HasParallelism, 
MLReadable, MLWritable):
    +class CrossValidator(Estimator, ValidatorParams, HasParallelism, 
HasCollectSubModels,
    --- End diff --
    
    Let's also clarify in the doc for CrossValidatorModel.copy() that it does 
not copy the extra Params into the subModels.  (same for 
TrainValidationSplitModel)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to