Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20904#discussion_r181230965
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTest.scala ---
    @@ -81,32 +81,37 @@ object KolmogorovSmirnovTest {
        * Java-friendly version of `test(dataset: DataFrame, sampleCol: String, 
cdf: Double => Double)`
        */
       @Since("2.4.0")
    -  def test(dataset: DataFrame, sampleCol: String,
    -    cdf: Function[java.lang.Double, java.lang.Double]): DataFrame = {
    -    val f: Double => Double = x => cdf.call(x)
    -    test(dataset, sampleCol, f)
    +  def test(
    +      dataset: Dataset[_],
    +      sampleCol: String,
    +      cdf: Function[java.lang.Double, java.lang.Double]): DataFrame = {
    +    test(dataset, sampleCol, (x: Double) => cdf.call(x))
    --- End diff --
    
    This is the 2nd time I've merged something which broke the Scala 2.12 
build.  If we care about Scala 2.12, do you know if there are any efforts to 
add PR builder tests for 2.12?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to