Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21048#discussion_r181357794
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/CheckpointFileManagerSuite.scala
 ---
    @@ -0,0 +1,192 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.sql.execution.streaming
    +
    +import java.io._
    +import java.net.URI
    +
    +import scala.util.Random
    +
    +import org.apache.hadoop.conf.Configuration
    +import org.apache.hadoop.fs._
    +
    +import org.apache.spark.SparkFunSuite
    +import org.apache.spark.sql.catalyst.util.quietly
    +import org.apache.spark.sql.internal.SQLConf
    +import org.apache.spark.sql.test.SharedSparkSession
    +import org.apache.spark.util.Utils
    +
    +abstract class CheckpointFileManagerTests extends SparkFunSuite {
    +
    +  def createManager(path: Path): CheckpointFileManager
    +
    +  test("mkdirs, list, createAtomic, open, delete") {
    +    withTempPath { p =>
    +      val basePath = new Path(p.getAbsolutePath)
    +      val fm = createManager(basePath)
    +      // Mkdirs
    +      val dir = new Path(s"$basePath/dir/subdir/subsubdir")
    +      assert(!fm.exists(dir))
    +      fm.mkdirs(dir)
    +      assert(fm.exists(dir))
    +      fm.mkdirs(dir)
    --- End diff --
    
    if that fm.exists() call was replaced with an fm.getFileStatus() operation, 
as suggested earlier, this assert could be come 
`assert(fm.getFileStatus(dir).isDirectory)`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to