Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21052#discussion_r181378031
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/FilterEstimationSuite.scala
 ---
    @@ -357,6 +357,17 @@ class FilterEstimationSuite extends 
StatsEstimationTestBase {
           expectedRowCount = 3)
       }
     
    +  test("evaluateInSet with all zeros") {
    +    validateEstimatedStats(
    +      Filter(InSet(attrString, Set(3, 4, 5)),
    +        StatsTestPlan(Seq(attrString), 10,
    --- End diff --
    
    change rowCount from `10` to `0`? this is more reasonable for an empty 
table.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to