Github user jose-torres commented on a diff in the pull request:
    --- Diff: 
    @@ -18,18 +18,26 @@
     package org.apache.spark.sql.sources.v2.reader;
     import org.apache.spark.annotation.InterfaceStability;
    -import org.apache.spark.sql.sources.v2.reader.streaming.PartitionOffset;
    +import org.apache.spark.sql.Row;
    +import org.apache.spark.sql.catalyst.expressions.UnsafeRow;
    +import org.apache.spark.sql.vectorized.ColumnarBatch;
      * A mix-in interface for {@link DataReaderFactory}. Continuous data 
reader factories can
      * implement this interface to provide creating {@link DataReader} with 
particular offset.
    -public interface ContinuousDataReaderFactory<T> extends 
DataReaderFactory<T> {
    -  /**
    -   * Create a DataReader with particular offset as its startOffset.
    -   *
    -   * @param offset offset want to set as the DataReader's startOffset.
    -   */
    -  DataReader<T> createDataReaderWithOffset(PartitionOffset offset);
    --- End diff --
    Fine to remove this. We've deferred or reworked all of the things that were 
going to use this method; it makes sense to rethink how to provide this 
functionality after the rest is polished and stable-ish.


To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to