Github user jose-torres commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21029#discussion_r181834072
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/ContinuousDataReaderFactory.java
 ---
    @@ -18,18 +18,26 @@
     package org.apache.spark.sql.sources.v2.reader;
     
     import org.apache.spark.annotation.InterfaceStability;
    -import org.apache.spark.sql.sources.v2.reader.streaming.PartitionOffset;
    +import org.apache.spark.sql.Row;
    +import org.apache.spark.sql.catalyst.expressions.UnsafeRow;
    +import 
org.apache.spark.sql.sources.v2.reader.streaming.ContinuousDataReader;
    +import org.apache.spark.sql.vectorized.ColumnarBatch;
     
     /**
      * A mix-in interface for {@link DataReaderFactory}. Continuous data 
reader factories can
      * implement this interface to provide creating {@link DataReader} with 
particular offset.
      */
     @InterfaceStability.Evolving
    -public interface ContinuousDataReaderFactory<T> extends 
DataReaderFactory<T> {
    -  /**
    -   * Create a DataReader with particular offset as its startOffset.
    -   *
    -   * @param offset offset want to set as the DataReader's startOffset.
    -   */
    -  DataReader<T> createDataReaderWithOffset(PartitionOffset offset);
    --- End diff --
    
    Fine to remove this. We've deferred or reworked all of the things that were 
going to use this method; it makes sense to rethink how to provide this 
functionality after the rest is polished and stable-ish.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to