Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19868#discussion_r182075222
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala ---
    @@ -70,6 +71,45 @@ class QueryPartitionSuite extends QueryTest with 
SQLTestUtils with TestHiveSingl
         }
       }
     
    +  test("Replace spark.sql.hive.verifyPartitionPath by 
spark.files.ignoreMissingFiles") {
    +    withSQLConf((SQLConf.HIVE_VERIFY_PARTITION_PATH.key, "false")) {
    +      sparkContext.conf.set(IGNORE_MISSING_FILES.key, "true")
    +      val testData = sparkContext.parallelize(
    +        (1 to 10).map(i => TestData(i, i.toString))).toDF()
    +      testData.createOrReplaceTempView("testData")
    +
    +      val tmpDir = Files.createTempDir()
    --- End diff --
    
    we should call `withTempDir`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to