Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21193#discussion_r188857554
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
 ---
    @@ -114,6 +114,113 @@ object JavaCode {
       }
     }
     
    +/**
    + * A trait representing a block of java code.
    + */
    +trait Block extends JavaCode {
    +
    +  // The expressions to be evaluated inside this block.
    +  def exprValues: Seq[ExprValue]
    --- End diff --
    
    yes, I think it is not and we are keeping here the order of the first 
occurrence (so for instance if we want to check which is the last reference we 
can't really know). I think a `Set` would be better since it enforces what we 
are keeping here, it avoids all the distinct (which we may forget to add 
somewhere getting a bad result...)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to