Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21165#discussion_r188925889
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
    @@ -1868,15 +1868,26 @@ class DAGSchedulerSuite extends SparkFunSuite with 
LocalSparkContext with TimeLi
         val accUpdate3 = new LongAccumulator
         accUpdate3.metadata = acc3.metadata
         accUpdate3.setValue(18)
    -    val accumUpdates = Seq(accUpdate1, accUpdate2, accUpdate3)
    -    val accumInfo = accumUpdates.map(AccumulatorSuite.makeInfo)
    +
    +    val accumUpdates1 = Seq(accUpdate1, accUpdate2)
    +    val accumInfo1 = accumUpdates1.map(AccumulatorSuite.makeInfo)
         val exceptionFailure = new ExceptionFailure(
           new SparkException("fondue?"),
    -      accumInfo).copy(accums = accumUpdates)
    +      accumInfo1).copy(accums = accumUpdates1)
    --- End diff --
    
    not caused by you but why we do a copy instead of passing `accumUpdates1` 
to the constructor directly?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to