Github user mgaido91 commented on a diff in the pull request:
    --- Diff: 
    @@ -1126,9 +1130,9 @@ case class ElementAt(left: Expression, right: 
Expression) extends GetMapValueUti
     case class Concat(children: Seq[Expression]) extends Expression {
    -  private val MAX_ARRAY_LENGTH: Int = 
    +  private def maxArrayLength: Int = 
    --- End diff --
    since `ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH` is a static value, what 
about using directly it in the methods instead of defining a quite useless def?


To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to