Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21352#discussion_r188953863
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
 ---
    @@ -1126,9 +1130,9 @@ case class ElementAt(left: Expression, right: 
Expression) extends GetMapValueUti
       """)
     case class Concat(children: Seq[Expression]) extends Expression {
     
    -  private val MAX_ARRAY_LENGTH: Int = 
ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH
    +  private def maxArrayLength: Int = 
ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH
    --- End diff --
    
    since `ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH` is a static value, what 
about using directly it in the methods instead of defining a quite useless def?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to