Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21378#discussion_r191056976
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
 ---
    @@ -418,17 +417,34 @@ private[spark] class MesosClusterScheduler(
         envBuilder.build()
       }
     
    +  private def isContainerLocalAppJar(desc: MesosDriverDescription): 
Boolean = {
    +    val isLocalJar = desc.jarUrl.startsWith("local://")
    +    val isContainerLocal = 
desc.conf.getOption("spark.mesos.appJar.local.resolution.mode").exists {
    --- End diff --
    
    instead of `.exists` shouldn't this be `.flatmap`?
    
    also does `case other` handles the case when the option is unset?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to