Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21730#discussion_r201678881
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/RuntimeConfigSuite.scala ---
    @@ -54,4 +54,15 @@ class RuntimeConfigSuite extends SparkFunSuite {
           conf.get("k1")
         }
       }
    +
    +  test("SPARK-24761: is a config parameter modifiable") {
    +    val conf = newConf()
    +
    +    // SQL configs
    +    
assert(!conf.isModifiable("spark.sql.sources.schemaStringLengthThreshold"))
    --- End diff --
    
    nit: add a case for nonexistent sql conf key?
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to