Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22081#discussion_r209707448
  
    --- Diff: pom.xml ---
    @@ -984,24 +987,15 @@
               </exclusion>
             </exclusions>
           </dependency>
    -      <!-- See SPARK-1556 for info on this dependency: -->
    +      <!-- See SPARK-23654 for info on this dependency;
    +      It is used to keep javax.activation at v1.1.1 after dropping
    +      jets3t as a dependency.
    +       -->
           <dependency>
    -        <groupId>net.java.dev.jets3t</groupId>
    -        <artifactId>jets3t</artifactId>
    -        <version>${jets3t.version}</version>
    +        <groupId>javax.activation</groupId>
    +        <artifactId>activation</artifactId>
    +        <version>1.1.1</version>
    --- End diff --
    
    the reason for the activation is that it still comes in from somewhere and 
the version pulled in drops from 1.1.1 to 1.1; meaning it'd be an accidental 
downgrade of a JAR. I don't know exactly what uses javax.activation: it is one 
of those historical artifacts whose main role, mapping mime types, is 
potentially used somewhere important. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to