Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22263#discussion_r225608012
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
    @@ -288,6 +297,65 @@ class CachedTableSuite extends QueryTest with 
SQLTestUtils with SharedSQLContext
         }
       }
     
    +  test("SQL interface support storageLevel(DISK_ONLY)") {
    --- End diff --
    
    @wangyum . Could you refactor the following four positive test cases by 
reducing the duplication? They are mostly the same except SQL statements and 
`StorageLevel`s.
    ```scala
    test("SQL interface support storageLevel(DISK_ONLY)")
    test("SQL interface select from table support storageLevel(DISK_ONLY)")
    test("SQL interface support storageLevel(DISK_ONLY) with invalid options")
    test("SQL interface support storageLevel(MEMORY_ONLY)")
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to