Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22263#discussion_r226215310
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
    @@ -288,6 +297,65 @@ class CachedTableSuite extends QueryTest with 
SQLTestUtils with SharedSQLContext
         }
       }
     
    +  test("SQL interface support storageLevel(DISK_ONLY)") {
    --- End diff --
    
    Can we do the following? Then, those 4 function will have one-line body.
    1. Let's remove `tableName: String,`. We can use the same table name.
    2. With (1), we can remove the common prefix, `CACHE TABLE testData 
OPTIONS(`, too.
    3. With (1) and (2), we can change `sqlStr: String` -> `options: String`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to