Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22877#discussion_r229034778
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -408,15 +408,16 @@ object SQLConf {
     
       val PARQUET_FILTER_PUSHDOWN_DATE_ENABLED = 
buildConf("spark.sql.parquet.filterPushdown.date")
         .doc("If true, enables Parquet filter push-down optimization for Date. 
" +
    -      "This configuration only has an effect when 
'spark.sql.parquet.filterPushdown' is enabled.")
    +      s"This configuration only has an effect when 
'${PARQUET_FILTER_PUSHDOWN_ENABLED.key}' is " +
    --- End diff --
    
    nit: Can we apply the same policy to `spark.sql.parquet.compression.codec` 
at L397?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to