Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22986#discussion_r233101747
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -538,7 +538,7 @@ private[ml] object GBTClassifierParams {
Array("logistic").map(_.toLowerCase(Locale.ROOT))
}
-private[ml] trait GBTClassifierParams extends GBTParams with
TreeClassifierParams {
+private[ml] trait GBTClassifierParams extends GBTParams with
TreeRegressorParams {
--- End diff --
That's preferable to extending the 'wrong' trait. Hm, can
TreeClassifierParams not just allow all impurity values? and have
GBTClassifierParams set it to "variance" in the constructor? that sounds more
correct. I know you guys have looked into it more but I still wasn't clear why
this wasn't an option.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
