srowen commented on a change in pull request #23357: [SPARK-26451][SQL] Change lead/lag argument name from count to offset URL: https://github.com/apache/spark/pull/23357#discussion_r244163919
########## File path: python/pyspark/sql/functions.py ########## @@ -798,7 +798,7 @@ def factorial(col): # --------------- Window functions ------------------------ @since(1.4) -def lag(col, count=1, default=None): +def lag(col, offset=1, default=None): Review comment: Yeah that would be most conservative; I think we could fix it in 3.0 as a bug without this, but I'm OK with it too. If, weirdly, someone sets both, the old value would override the new, but maybe that's fine as corner case behavior. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
