mgaido91 commented on a change in pull request #23384: [SPARK-26443 ][CORE] Use
ConfigEntry for hardcoded configs for history category.
URL: https://github.com/apache/spark/pull/23384#discussion_r244428831
##########
File path:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala
##########
@@ -78,8 +78,8 @@ class HistoryServerSuite extends SparkFunSuite with
BeforeAndAfter with Matchers
Utils.deleteRecursively(storeDir)
assert(storeDir.mkdir())
val conf = new SparkConf()
- .set("spark.history.fs.logDirectory", logDir)
- .set("spark.history.fs.update.interval", "0")
+ .set(EVENT_LOG_DIR, logDir)
Review comment:
actually I am fine with both, this was rather a nit, I just meant to have
one notation instead of both them if possible, in order to avoid confusion. But
if you prefer this way, I am fine with it, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
