mgaido91 commented on a change in pull request #23531: [SPARK-24497][SQL]
Support recursive SQL query
URL: https://github.com/apache/spark/pull/23531#discussion_r247539199
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -289,13 +294,13 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
extends Product {
/**
* Returns a copy of this node where `f` has been applied to all the nodes
children.
*/
- def mapChildren(f: BaseType => BaseType): BaseType = {
- if (children.nonEmpty) {
+ def mapChildren(f: BaseType => BaseType, forceCopy: Boolean = false):
BaseType = {
Review comment:
I see, my point is that this is a very critical method, so I'd prefer to
leave it unchanged. Do we really need that makeDeepCopy? If so, why do we need
it? I hope we can rid of it somehow...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
