srowen commented on a change in pull request #23549: [SPARK-26616][MLlib]
Expose document frequency in IDFModel
URL: https://github.com/apache/spark/pull/23549#discussion_r248020044
##########
File path: python/pyspark/ml/tests/test_feature.py
##########
@@ -67,7 +67,9 @@ def test_idf(self):
"Model should inherit the UID from its parent
estimator.")
output = idf0m.transform(dataset)
self.assertIsNotNone(output.head().idf)
- # Test that parameters transferred to Python Model
+ self.assertIsNotNone(idf0m.df)
+ self.assertEqual(idf0m.numDocs, 3)
+ # Test that parameters transferred to Python Model
Review comment:
Nit: fix the indent here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
