cloud-fan opened a new pull request #23692: [SPARK-26448][SQL][followup] should 
not normalize grouping expressions for final aggregate
URL: https://github.com/apache/spark/pull/23692
 
 
   ## What changes were proposed in this pull request?
   
   A followup of https://github.com/apache/spark/pull/23388 .
   
   `AggUtils.createAggregate` is not the right place to normalize the grouping 
expressions, as final aggregate is also created by it. The grouping expressions 
of final aggregate should be attributes which refer to the grouping expressions 
in partial aggregate.
   
   This PR moves the normalization to the caller side of `AggUtils`.
   
   ## How was this patch tested?
   
   existing tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to