viirya commented on a change in pull request #23692:
[SPARK-26448][SQL][followup] should not normalize grouping expressions for
final aggregate
URL: https://github.com/apache/spark/pull/23692#discussion_r252202677
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -331,8 +332,17 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
val stateVersion =
conf.getConf(SQLConf.STREAMING_AGGREGATION_STATE_FORMAT_VERSION)
+ // Ideally this should be done in `NormalizeFloatingNumbers`, but we
do it here because
Review comment:
Don't we need to remove it from `AggUtils.createAggregate`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
