dongjoon-hyun commented on a change in pull request #24469: [SPARK-27576][SQL]
table capability to skip the output column resolution
URL: https://github.com/apache/spark/pull/24469#discussion_r279609139
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NamedRelation.scala
##########
@@ -21,4 +21,7 @@ import
org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
trait NamedRelation extends LogicalPlan {
def name: String
+
+ // When true, the schema of input data must match the schema of this
relation, during write.
+ def requireSchemaMatch: Boolean = true
Review comment:
Can we use `def ignoreSchemaMatch: Boolean = false` because we have only one
instance and it's negative form.
```scala
- !table.requireSchemaMatch || {
+ table.ignoreSchemaMatch || {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
