dongjoon-hyun commented on a change in pull request #24851: 
[SPARK-27303][GRAPH] Add PropertyGraph construction API
URL: https://github.com/apache/spark/pull/24851#discussion_r292997721
 
 

 ##########
 File path: 
graph/api/src/test/java/org/apache/spark/graph/api/JavaPropertyGraphSuite.java
 ##########
 @@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.graph.api;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Sets;
+import org.apache.spark.sql.Dataset;
+import org.apache.spark.sql.Row;
+import org.apache.spark.sql.RowFactory;
+import org.apache.spark.sql.test.TestSparkSession;
+import org.apache.spark.sql.types.DataType;
+import org.apache.spark.sql.types.DataTypes;
+import org.apache.spark.sql.types.StructField;
+import org.apache.spark.sql.types.StructType;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+
+public abstract class JavaPropertyGraphSuite implements Serializable {
+    private transient TestSparkSession spark;
+    private transient CypherSession cypherSession = null;
+
+    @Before
+    public void setUp() {
+        spark = new TestSparkSession();
+    }
+
+    @After
+    public void tearDown() {
+        spark.stop();
+        spark = null;
+    }
+
+    @Test
+    public void testCreateFromNodeFrame() {
+        StructType personSchema = createSchema(
+                Lists.newArrayList("id", "name"),
+                Lists.newArrayList(DataTypes.LongType, DataTypes.StringType));
+
+        List<Row> personData = Arrays.asList(
+                RowFactory.create(0L, "Alice"),
+                RowFactory.create(1L, "Bob"));
+
+        StructType knowsSchema = createSchema(
+                Lists.newArrayList("id", "source", "target", "since"),
+                Lists.newArrayList(DataTypes.LongType, DataTypes.LongType, 
DataTypes.LongType, DataTypes.IntegerType));
+
+        List<Row> knowsData = Collections.singletonList(RowFactory.create(0L, 
0L, 1L, 1984));
+
+        Dataset<Row> personDf = spark.createDataFrame(personData, 
personSchema);
+        NodeFrame personNodeFrame = NodeFrame.create(personDf, "id", 
Sets.newHashSet("Person"));
+
+        Dataset<Row> knowsDf = spark.createDataFrame(knowsData, knowsSchema);
+        RelationshipFrame knowsRelFrame = RelationshipFrame.create(knowsDf, 
"id", "source", "target", "KNOWS");
+
+        PropertyGraph graph = 
cypherSession.createGraph(Lists.newArrayList(personNodeFrame), 
Lists.newArrayList(knowsRelFrame));
+        List<Row> result = graph.nodes().collectAsList();
+        Assert.assertEquals(1, result.size());
+    }
+
+    private StructType createSchema(List<String> fieldNames, List<DataType> 
dataTypes) {
+        List<StructField> fields = new ArrayList<>();
+        for (int i = 0; i < fieldNames.size(); i++) {
+            fields.add(DataTypes.createStructField(fieldNames.get(i), 
dataTypes.get(i), true));
+        }
+        return DataTypes.createStructType(fields);
+    }
+}
 
 Review comment:
   FYI, Apache Spark uses 2-space indentation for Java code, too. Please fix 
this one and consider that in the next PRs.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to