carsonwang commented on a change in pull request #25121: [SPARK-28356][SQL] Do 
not reduce the number of partitions for repartition in adaptive execution
URL: https://github.com/apache/spark/pull/25121#discussion_r302817560
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -312,6 +312,16 @@ object SQLConf {
     .booleanConf
     .createWithDefault(true)
 
+  val REDUCE_POST_SHUFFLE_PARTITIONS_FOR_REPARTITION =
 
 Review comment:
   I initially didn't add this config.  Later I found with that change, the 
`test("Union two datasets with different pre-shuffle partition number")` won't 
test what we want to test, because it was written using repartition. Probably I 
can rewrite that test without using repartition. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to