imback82 commented on a change in pull request #25247: [SPARK-28319][SQL]
Implement SHOW TABLES for Data Source V2 Tables
URL: https://github.com/apache/spark/pull/25247#discussion_r310435260
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala
##########
@@ -163,6 +163,24 @@ case class DataSourceResolution(
case DataSourceV2Relation(CatalogTableAsV2(catalogTable), _, _) =>
UnresolvedCatalogRelation(catalogTable)
+ case ShowTablesStatement(None, pattern) =>
+ defaultCatalog match {
+ case Some(_) =>
+ throw new AnalysisException(
+ "v2 catalog doesn't support getCurrentDatabase yet, " +
+ "so the default database name cannot be deduced.")
+ case None =>
+ ShowTablesCommand(None, pattern)
+ }
+
+ case plan @ ShowTablesStatement(Some(namespace), pattern) =>
+ val CatalogObjectIdentifier(maybeCatalog, identifier) = namespace
+ val catalog = maybeCatalog.orElse(defaultCatalog)
Review comment:
Yes you are right. `CatalogObjectIdentifier` will fill in the default
catalog. I will remove this and also update these above:
```
case replace: ReplaceTableStatement =>
// the provider was not a v1 source, convert to a v2 plan
val CatalogObjectIdentifier(maybeCatalog, identifier) =
replace.tableName
val catalog = maybeCatalog.orElse(defaultCatalog)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
