dongjoon-hyun commented on a change in pull request #25426:
[SPARK-28703][SQL][TEST] Skip test HiveExternalCatalogVersionsSuite and skip 3
tests in HiveSparkSubmitSuite when testing with JAVA_9 or later
URL: https://github.com/apache/spark/pull/25426#discussion_r313202639
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
##########
@@ -201,7 +201,16 @@ class HiveExternalCatalogVersionsSuite extends
SparkSubmitTestUtils {
tempPyFile.delete()
}
+ override def beforeAll(): Unit = {
+ super.beforeAll()
+ if (!isTestAtLeastJava9) {
+ prepare()
+ }
+ }
+
test("backward compatibility") {
+ // TODO Test backward compatibility on JAVA_9 once we have a version
supports JAVA_9
Review comment:
Please file a JIRA and make this IDed TODO, @wangyum .
Otherwise, it's very difficult for the other contributors to pick up this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
