dongjoon-hyun commented on a change in pull request #25439: 
[SPARK-28709][DSTREAMS] - Fix StreamingContext leak through Streaming…
URL: https://github.com/apache/spark/pull/25439#discussion_r313624949
 
 

 ##########
 File path: 
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala
 ##########
 @@ -575,6 +577,8 @@ class StreamingContext private[streaming] (
           try {
             validate()
 
+            registerProgressListener()
 
 Review comment:
   I understand you are suggesting that the unregister is important, but do we 
need this? This seems to be a behavior change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to