HyukjinKwon commented on a change in pull request #20826: [SPARK-2489][SQL] 
Support Parquet's optional fixed_len_byte_array
URL: https://github.com/apache/spark/pull/20826#discussion_r313675924
 
 

 ##########
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetAvroCompatibilitySuite.scala
 ##########
 @@ -47,6 +47,14 @@ class ParquetAvroCompatibilitySuite extends 
ParquetCompatibilityTest with Shared
     try f(writer) finally writer.close()
   }
 
+  private def generateFixedLengthByteArray(i : Int): Array[Byte] = {
+    val fixedLengthByteArray = Array[Byte](0, 0, 0, 0, 0, 0, 0, 0)
+    val fixedLengthByteArrayComponent = 
s"val_$i".getBytes(StandardCharsets.UTF_8)
 
 Review comment:
   nit `s` seems not needed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to