shahidki31 commented on a change in pull request #25460: 
[SPARK-25474][SQL][FOLLOW-UP] fallback to hdfs when relation table stats is not 
available
URL: https://github.com/apache/spark/pull/25460#discussion_r314349801
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFsRelation.scala
 ##########
 @@ -72,7 +72,8 @@ case class HadoopFsRelation(
     val compressionFactor = sqlContext.conf.fileCompressionFactor
     val defaultSize = (location.sizeInBytes * compressionFactor).toLong
     location match {
-      case cfi: CatalogFileIndex if 
sparkSession.sessionState.conf.fallBackToHdfsForStatsEnabled =>
+      case cfi: CatalogFileIndex if 
sparkSession.sessionState.conf.fallBackToHdfsForStatsEnabled
+        && defaultSize == sqlContext.conf.defaultSizeInBytes =>
 
 Review comment:
   @wangyum (location.sizeInBytes * compressionFactor).toLong is always 8.0EB, 
even after the PR #24715 
   I am not sure I understand your comment.  If the statistics doesn't exists, 
it has to fallback to HDFS. right? Next time onwards it will read from stats 
cache.
   
   Number of times falling back to HDFS after this PR and #24715 are also same. 
right?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to