tgravescs commented on a change in pull request #25409: [SPARK-28414][WEBUI] UI updates to show resource info in Standalone URL: https://github.com/apache/spark/pull/25409#discussion_r314355991
########## File path: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala ########## @@ -185,6 +185,7 @@ private[deploy] class Worker( var coresUsed = 0 var memoryUsed = 0 + val resourcesUsed = new HashMap[String, ResourceInformation]() Review comment: Yeah I don't think you should use REsourceInformation here to track used since like you said its immutable. We don't want to change that to be mutable because its user facing API. Something more like WorkerResourceInfo would make sense ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
