AngersZhuuuu opened a new pull request #25469: 
[SPARK-27637][Shuffle][FLLOW-UP]For nettyBlockTransferService, if IOException 
occurred while create client, check whether relative executor is alive before 
retry #24533
URL: https://github.com/apache/spark/pull/25469
 
 
   ### What changes were proposed in this pull request?
   
   In pr #[24533](https://github.com/apache/spark/pull/24533/files) , it 
prevent retry to an removed Executor. 
   In my test, I can't catch exceptions from 
   ` new OneForOneBlockFetcher(client, appId, execId, blockIds, listener,
                 transportConf, tempFileManager).start()`
   And I check the code carefully´╝î method **start()** will handle exception of 
IOException in it's retry logical, won't throw it out. until it meet maxRetry 
times or meet exception that is not  IOException. 
   
   And if we meet the situation that when we fetch block , the executor is 
dead, when we rerun 
   `RetryingBlockFetcher.BlockFetchStarter.createAndStart()`
   we may failed when we create a transport client to dead executor. it will 
throw a IOException. 
   We should catch this IOException.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes 
- provide the console output, description and/or an example to show the 
behavior difference if possible.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to