cloud-fan commented on a change in pull request #25491: [SPARK-28699][SQL]
Disable using radix sort for ShuffleExchangeExec in repartition case
URL: https://github.com/apache/spark/pull/25491#discussion_r315507679
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
##########
@@ -264,7 +264,11 @@ object ShuffleExchangeExec {
prefixComparator,
prefixComputer,
pageSize,
- canUseRadixSort)
+ // As we need to compare the binary of UnsafeRow here, we can't
make sure whether all
+ // the fields can sort fully with prefix like SortExec. So we
disable radix sort here
+ // to avoid getting unstable sort, and result to a correctness bug.
+ // See more details in SPARK-28699.
Review comment:
I have one more: https://github.com/apache/spark/pull/25498 , which will be
merged soon, after tests pass.
The current PR may need more time. We need to collect feedback about whether
we should disable "sort before repartition" by default. cc @jiangxb1987
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
