srowen commented on issue #25678: [SPARK-28973][SQL] Add `TimeType` and support 
`java.time.LocalTime` as its external type.
URL: https://github.com/apache/spark/pull/25678#issuecomment-529986667
 
 
   It looks pretty thorough to me. I don't see a problem with supporting 
`LocalTime` as microseconds since midnight. 
   
   You're right that the more important question is whether introducing a 
catalyst `TimeType` causes any subtler problems. For example, what if I write 
this type as Parquet? I get a long type out? are there any related types in 
Parquet or otherwise that we need to consider the behavior of, whether it's 
consistent with those? I don't know, those are just the questions I'd have to 
decide if there is any issue here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to