cloud-fan commented on issue #25651: [SPARK-28948][SQL] Support passing all Table metadata in TableProvider URL: https://github.com/apache/spark/pull/25651#issuecomment-534813380 @rdblue yea it's possible. In this PR, I try to adopt your suggestion to make it clear that `TableProvider.getTable` should take all the table metadata, so the method signature becomes ``` def getTable(schema: StructType, partitions: Array[Transform], properties: Map[String, String]) ``` `TableProvider` has another `getTable` method which needs to infer schema/partitioning, and previously the method signature was ``` def getTable(options: CaseInsensitiveStringMap) ``` To make it consistent, I change it to use `properties: Map[String, String]`, also rename it to `loadTable` since we need to touch many files anyway. We can still keep the old method signature with a TODO to change it later, so that this PR can be much smaller.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
