MaxGekk commented on issue #25924: [SPARK-29237][SQL][DOC] Avoid usage of function names in expression examples URL: https://github.com/apache/spark/pull/25924#issuecomment-534992519 I do believe it is worth because it is added not only for particular test, this check will prevent mistakes in docs. ср, 25 сент. 2019 г. в 14:26, Sean Owen <[email protected]>: > *@srowen* commented on this pull request. > ------------------------------ > > In > sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionInfo.java > <https://github.com/apache/spark/pull/25924#discussion_r328066642>: > > > @@ -56,6 +56,8 @@ public String getArguments() { > return arguments; > } > > + public String getOriginalExamples() { return examples; } > > I don't know that this is worth adding just for testing? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/25924?email_source=notifications&email_token=AAMB5GL3IFHF6434L2UILNDQLNDFVA5CNFSM4I2INPP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCF3OHLY#pullrequestreview-293004207>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAMB5GIPOO2MU2E7YINXUR3QLNDFVANCNFSM4I2INPPQ> > . > -- Yours faithfully, Maxim Gekk http://www.linkedin.com/in/maxgekk
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
