merrily01 edited a comment on issue #25920: [SPARK-29233][KUBERNETES] Add regex expression checks for executorEnv… URL: https://github.com/apache/spark/pull/25920#issuecomment-535341503 Hey~ @srowen I was so sleepy last night that my mind was a little unclear. After my careful consideration, I have something to tell you: 1. This validation is necessary, otherwise an executor environment variable name that does not conform to the specification will lead to pod creation errors. 2. As you know, this check rule is different in high and low versions of k8s.(The low version is stricter than the high version) That means there will be no problem for low to high versions of k8s, but in the case of high to low versions，k8s itself may also have this problem. 3. Compatibility can be achieved with lower version regex (Stricter), but this is contrary to the original intention of the high version of k8s to make this change. 4. I prefer the validation here to be consistent with the high version behavior of k8s, rather than considering this as a compatibility issue. 5. What do you think if I declare it in the notes and log message?For example, as follows： 
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
