zsxwing commented on a change in pull request #26077: 
[SPARK-29413][CORE][FOLLOWUP] A better parmap method signature
URL: https://github.com/apache/spark/pull/26077#discussion_r333264618
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala
 ##########
 @@ -274,12 +274,19 @@ private[spark] object ThreadUtils {
    * @return new collection in which each element was given from the input 
collection `in` by
    *         applying the lambda function `f`.
    */
-  def parmap[I, O](in: Seq[I], prefix: String, maxThreads: Int)(f: I => O): 
Seq[O] = {
+  def parmap[I, O, Col[X] <: TraversableOnce[X]]
 
 Review comment:
   Hm, `CanBuildFrom` doesn't exist in 2.13 either. Then we have to write two 
versions for 2.12 and 2.13. Hence, I'm okey to just use `Seq` instead. Adding 
`asInstanceOf` if necessary is better than two versions of codes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to