advancedxy commented on a change in pull request #26040: [SPARK-9853][Core]
Optimize shuffle fetch of continuous partition IDs
URL: https://github.com/apache/spark/pull/26040#discussion_r333860050
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleIndexInformation.java
##########
@@ -53,9 +53,9 @@ public int getSize() {
/**
* Get index offset for a particular reducer.
*/
- public ShuffleIndexRecord getIndex(int reduceId) {
- long offset = offsets.get(reduceId);
- long nextOffset = offsets.get(reduceId + 1);
+ public ShuffleIndexRecord getIndex(int startReduceId, int endReduceId) {
Review comment:
This is a public method, do we need to add a new method instead to achieve
binary compatibility?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
