srowen commented on a change in pull request #26057: [SPARK-29377][PYTHON][ML]
Parity between Scala ML tuning and Python ML tuning
URL: https://github.com/apache/spark/pull/26057#discussion_r334285174
##########
File path: python/pyspark/ml/tuning.py
##########
@@ -261,19 +260,30 @@ def setParams(self, estimator=None,
estimatorParamMaps=None, evaluator=None, num
kwargs = self._input_kwargs
return self._set(**kwargs)
- @since("1.4.0")
- def setNumFolds(self, value):
+ def setEstimator(self, value):
"""
- Sets the value of :py:attr:`numFolds`.
+ Sets the value of :py:attr:`estimator`.
"""
- return self._set(numFolds=value)
+ return self._set(estimator=value)
+
+ def setEstimatorParamMaps(self, value):
+ """
+ Sets the value of :py:attr:`estimatorParamMaps`.
+ """
+ return self._set(estimatorParamMaps=value)
+
+ def setEvaluator(self, value):
Review comment:
`@since 2.0` is at least accurate, as both have existed since that version.
One existed before, sure, but this is maybe not a big deal, as it won't matter
much at all to know it was in 1.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
