yaooqinn opened a new pull request #26573: [SPARK-29926][SQL] Fix weird interval string whose value end with a dangling decimal point URL: https://github.com/apache/spark/pull/26573 ### What changes were proposed in this pull request? <!-- Currently, we support to parse '1. second' to 1s or even '. second' to 0s. ```sql -- !query 118 select interval '1. seconds' -- !query 118 schema struct<1 seconds:interval> -- !query 118 output 1 seconds -- !query 119 select interval '. seconds' -- !query 119 schema struct<0 seconds:interval> -- !query 119 output 0 seconds ``` ```sql postgres=# select interval '1. second'; ERROR: invalid input syntax for type interval: "1. second" LINE 1: select interval '1. second'; postgres=# select interval '. second'; ERROR: invalid input syntax for type interval: ". second" LINE 1: select interval '. second'; ``` We fix this by fixing the new interval parser's VALUE_FRACTIONAL_PART state ### Why are the changes needed? bug fix ### Does this PR introduce any user-facing change? <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If no, write 'No'. --> yes, now we treat '1. seconds', '. second' .... as invalid intervals ### How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> add ut
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
