cloud-fan commented on a change in pull request #26622:
[WIP][SPARK-28023][Test] Cheap UTF8String Trim
URL: https://github.com/apache/spark/pull/26622#discussion_r348961154
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -1077,6 +1090,7 @@ public UTF8String translate(Map<Character, Character>
dict) {
* @return true if the parsing was successful else false
*/
public boolean toLong(LongWrapper toLongResult) {
Review comment:
let's not make this method has side effect. We should only change the local
variable `offset` inside this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
