deshanxiao opened a new pull request #26744: [SPARK-30106][SQL][TEST] Fix the 
test of DynamicPartitionPruningSuite
URL: https://github.com/apache/spark/pull/26744
 
 
   ### What changes were proposed in this pull request?
   Changed the test **DPP triggers only for certain types of query** in 
**DynamicPartitionPruningSuite**.
   
   
   ### Why are the changes needed?
   The sql has no partition key. The description "no predicate on the dimension 
table" is not right. So fix it.
   ```
         Given("no predicate on the dimension table")
         withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true") {
           val df = sql(
             """
               |SELECT * FROM fact_sk f
               |JOIN dim_store s
               |ON f.date_id = s.store_id
             """.stripMargin)
   ```
   
   
   ### Does this PR introduce any user-facing change?
   No
   
   
   ### How was this patch tested?
   Updated test
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to