cloud-fan commented on a change in pull request #26537: [SPARK-29587][SQL]
Support SQL Standard type real as float(4) numeric as decimal
URL: https://github.com/apache/spark/pull/26537#discussion_r356014143
##########
File path: sql/core/src/test/resources/sql-tests/inputs/show-create-table.sql
##########
@@ -59,3 +59,8 @@ TBLPROPERTIES ('a' = '1');
SHOW CREATE TABLE tbl;
DROP TABLE tbl;
+
+-- new real/numeric type
Review comment:
What we need to prove is the alias works. I think this test is good enough
(no need to test it in cast), but we should update the comment. It's not new
types, but just alias.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
