yaooqinn commented on a change in pull request #26905: [SPARK-30266][SQL] Avoid
match error and int overflow in ApproximatePercentile
URL: https://github.com/apache/spark/pull/26905#discussion_r358867153
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala
##########
@@ -214,7 +214,9 @@ object CommandUtils extends Logging {
val namedExprs = attrsToGenHistogram.map { attr =>
val aggFunc =
- new ApproximatePercentile(attr, Literal(percentiles),
Literal(conf.percentileAccuracy))
+ new ApproximatePercentile(attr,
+ Literal(new GenericArrayData(percentiles), ArrayType(DoubleType,
false)),
Review comment:
Literal(percentiles) creates ArrayType(_, containsNull = true)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
