brkyvz commented on a change in pull request #26913: [SPARK-29219][SQL]
Introduce SupportsCatalogOptions for TableProvider
URL: https://github.com/apache/spark/pull/26913#discussion_r360976159
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##########
@@ -258,37 +258,73 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) {
val dsOptions = new CaseInsensitiveStringMap(options.asJava)
import
org.apache.spark.sql.execution.datasources.v2.DataSourceV2Implicits._
- provider.getTable(dsOptions) match {
- case table: SupportsWrite if table.supports(BATCH_WRITE) =>
- if (partitioningColumns.nonEmpty) {
- throw new AnalysisException("Cannot write data to TableProvider
implementation " +
- "if partition columns are specified.")
+ mode match {
+ case SaveMode.Append | SaveMode.Overwrite =>
+ val table = provider match {
+ case supportsExtract: SupportsCatalogOptions =>
Review comment:
drop table gets a bit weird in overwrite mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
